chore: update bootstrap plugin export #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to: Plugin export collisions in character files Risks Low - This is a minor bug fix that ensures proper module exports Background What does this PR do? Ensures the bootstrap plugin has a proper default export at the bottom to avoid collisions when used in the actions module in character files. This maintains consistency with other plugins in the codebase that follow the same pattern (like the EVM plugin). What kind of change is this? Bug fixes (non-breaking change which fixes an issue) Documentation changes needed? My changes do not require a change to the project documentation. Testing Where should a reviewer start? Check packages/plugin-bootstrap/src/index.ts to verify the proper export structure Verify that the plugin can be properly imported in character files without collisions Detailed testing steps Load a character file that uses the bootstrap plugin Verify that no export collisions occur when the plugin is loaded Verify that all plugin actions are properly accessible Deploy Notes No special deploy steps required. This is a straightforward bug fix that maintains backward compatibility. Discord: affaanmustafa
mgunnin
approved these changes
Jan 4, 2025
monilpat
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Plugin export collisions in character files
Risks
Low - This is a minor bug fix that ensures proper module exports
Background
What does this PR do?
Ensures the bootstrap plugin has a proper default export at the bottom to avoid collisions when used in the actions module in character files. This maintains consistency with other plugins in the codebase that follow the same pattern (like the EVM plugin).
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Check packages/plugin-bootstrap/src/index.ts to verify the proper export structure Verify that the plugin can be properly imported in character files without collisions Detailed testing steps
Load a character file that uses the bootstrap plugin Verify that no export collisions occur when the plugin is loaded Verify that all plugin actions are properly accessible Deploy Notes
No special deploy steps required. This is a straightforward bug fix that maintains backward compatibility.
Discord:
affaanmustafa
Relates to
Risks
Background
What does this PR do?
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps