Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dex Screener plugin with token price action, evaluators, an… #1865

Merged
merged 16 commits into from
Jan 15, 2025

Conversation

hellopleasures
Copy link
Contributor

@hellopleasures hellopleasures commented Jan 5, 2025

…d providers

Relates to

Risks

Background

What does this PR do?

Fetch token price using DexSceenerAPI

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

  • give me price of {token_name}
    11111

odilitime
odilitime previously approved these changes Jan 5, 2025
ag-wnl
ag-wnl previously approved these changes Jan 5, 2025
@cre8tions
Copy link

cre8tions commented Jan 5, 2025

agent/package.json and agent/src/index.ts leaves merge tags in the file. There seems to be minor linter issues in the files as well.

also, having the solana plugin disabled, adding this eliza gives me 2 responses to the question "whats the price of ".

agent/package.json Outdated Show resolved Hide resolved
agent/src/index.ts Outdated Show resolved Hide resolved
@hellopleasures hellopleasures reopened this Jan 6, 2025
@hellopleasures hellopleasures reopened this Jan 6, 2025
@0xCardinalError
Copy link
Contributor

Duplicate for #1584 in name but not the functionality
I was fetching there latest tokens added. Should we combine these 2 into one PR. Do I commit mine actions here or vice versa since mine PR was older? @hellopleasures

@wtfsayo
Copy link
Member

wtfsayo commented Jan 15, 2025

Duplicate for #1584 in name but not the functionality I was fetching there latest tokens added. Should we combine these 2 into one PR. Do I commit mine actions here or vice versa since mine PR was older? @hellopleasures

can commit here

@0xCardinalError
Copy link
Contributor

Duplicate for #1584 in name but not the functionality I was fetching there latest tokens added. Should we combine these 2 into one PR. Do I commit mine actions here or vice versa since mine PR was older? @hellopleasures

can commit here

Isnt that not possible since its his repo, I probably don't have permission to do that unless I get ma maintainer role?

@wtfsayo
Copy link
Member

wtfsayo commented Jan 15, 2025

Duplicate for #1584 in name but not the functionality I was fetching there latest tokens added. Should we combine these 2 into one PR. Do I commit mine actions here or vice versa since mine PR was older? @hellopleasures

can commit here

Isnt that not possible since its his repo, I probably don't have permission to do that unless I get ma maintainer role?

fork the repo/branch or wait for merge on this one

@wtfsayo
Copy link
Member

wtfsayo commented Jan 15, 2025

@coderabbitai review

@0xCardinalError
Copy link
Contributor

Duplicate for #1584 in name but not the functionality I was fetching there latest tokens added. Should we combine these 2 into one PR. Do I commit mine actions here or vice versa since mine PR was older? @hellopleasures

can commit here

Isnt that not possible since its his repo, I probably don't have permission to do that unless I get ma maintainer role?

fork the repo/branch or wait for merge on this one

ok. i can do that

Copy link
Contributor

coderabbitai bot commented Jan 15, 2025

📝 Walkthrough

Walkthrough

The pull request introduces the @elizaos/plugin-dexscreener package, which is designed to manage token price queries. This package provides functionality for recognizing, evaluating, and retrieving token price information from the DexScreener API. It integrates with the existing agent framework by offering actions, evaluators, and providers specifically for token price interactions.

Changes

File Change Summary
agent/package.json Added @elizaos/plugin-dexscreener as a workspace dependency.
agent/src/index.ts Added imports for dexScreenerPlugin, stargazePlugin, and echoChambersPlugin; removed commented import for ReclaimAdapter.
packages/plugin-dexscreener/... New plugin package created with:
- Configuration files (.npmignore, eslint.config.mjs, tsconfig.json, tsup.config.ts)
- package.json defining package metadata
- Source files for actions, evaluators, and providers handling token price queries.

Finishing Touches

  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]

This comment was marked as outdated.

@wtfsayo
Copy link
Member

wtfsayo commented Jan 15, 2025

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
agent/src/index.ts (1)

101-106: ⚠️ Potential issue

Resolve merge conflict markers.

The merge conflict markers need to be removed.

Apply this diff to resolve the conflict:

-<<<<<<< HEAD
 import { echoChambersPlugin } from "@elizaos/plugin-echochambers";
 import { dexScreenerPlugin } from "@elizaos/plugin-dexscreener";
 import { stargazePlugin } from "@elizaos/plugin-stargaze";
-=======
->>>>>>> bd9d2151a509acb8da9d6e1dab9303d884498d74
🧰 Tools
🪛 Biome (1.9.4)

[error] 104-106: Expected a statement but instead found '=======

bd9d215'.

Expected a statement here.

(parse)


[error] 104-104: Shouldn't redeclare 'stargazePlugin'. Consider to delete it or rename it.

'stargazePlugin' is defined here:

(lint/suspicious/noRedeclare)

🧹 Nitpick comments (1)
agent/src/index.ts (1)

769-769: Add conditional check for dexScreenerPlugin.

For consistency with other plugins, consider adding a conditional check based on required environment variables or secrets.

Example pattern to follow:

-            dexScreenerPlugin,
+            getSecret(character, "DEXSCREENER_API_KEY") ? dexScreenerPlugin : null,
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fb31a6 and f12e771.

📒 Files selected for processing (2)
  • agent/package.json (1 hunks)
  • agent/src/index.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • agent/package.json
🧰 Additional context used
🪛 Biome (1.9.4)
agent/src/index.ts

[error] 104-106: Expected a statement but instead found '=======

bd9d215'.

Expected a statement here.

(parse)


[error] 104-104: Shouldn't redeclare 'stargazePlugin'. Consider to delete it or rename it.

'stargazePlugin' is defined here:

(lint/suspicious/noRedeclare)

wtfsayo
wtfsayo previously approved these changes Jan 15, 2025
@wtfsayo wtfsayo self-requested a review January 15, 2025 11:30
@wtfsayo wtfsayo merged commit 6381485 into elizaOS:develop Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants