-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Dex Screener plugin with token price action, evaluators, an… #1865
Conversation
dbee54e
to
ed16b0c
Compare
agent/package.json and agent/src/index.ts leaves merge tags in the file. There seems to be minor linter issues in the files as well. also, having the solana plugin disabled, adding this eliza gives me 2 responses to the question "whats the price of ". |
3e79696
to
fff2040
Compare
3d647e2
to
dc11461
Compare
4c61b86
to
bd9d215
Compare
Duplicate for #1584 in name but not the functionality |
can commit here |
Isnt that not possible since its his repo, I probably don't have permission to do that unless I get ma maintainer role? |
fork the repo/branch or wait for merge on this one |
@coderabbitai review |
ok. i can do that |
📝 WalkthroughWalkthroughThe pull request introduces the Changes
Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
agent/src/index.ts (1)
101-106
:⚠️ Potential issueResolve merge conflict markers.
The merge conflict markers need to be removed.
Apply this diff to resolve the conflict:
-<<<<<<< HEAD import { echoChambersPlugin } from "@elizaos/plugin-echochambers"; import { dexScreenerPlugin } from "@elizaos/plugin-dexscreener"; import { stargazePlugin } from "@elizaos/plugin-stargaze"; -======= ->>>>>>> bd9d2151a509acb8da9d6e1dab9303d884498d74🧰 Tools
🪛 Biome (1.9.4)
[error] 104-106: Expected a statement but instead found '=======
bd9d215'.
Expected a statement here.
(parse)
[error] 104-104: Shouldn't redeclare 'stargazePlugin'. Consider to delete it or rename it.
'stargazePlugin' is defined here:
(lint/suspicious/noRedeclare)
🧹 Nitpick comments (1)
agent/src/index.ts (1)
769-769
: Add conditional check for dexScreenerPlugin.For consistency with other plugins, consider adding a conditional check based on required environment variables or secrets.
Example pattern to follow:
- dexScreenerPlugin, + getSecret(character, "DEXSCREENER_API_KEY") ? dexScreenerPlugin : null,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
agent/package.json
(1 hunks)agent/src/index.ts
(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- agent/package.json
🧰 Additional context used
🪛 Biome (1.9.4)
agent/src/index.ts
[error] 104-106: Expected a statement but instead found '=======
bd9d215'.
Expected a statement here.
(parse)
[error] 104-104: Shouldn't redeclare 'stargazePlugin'. Consider to delete it or rename it.
'stargazePlugin' is defined here:
(lint/suspicious/noRedeclare)
…d providers
Relates to
Risks
Background
What does this PR do?
Fetch token price using DexSceenerAPI
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps