Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Minor Improvement: Add suppressInitialMessage to webSearch Action #2066

Closed
wants to merge 3 commits into from

Conversation

chuasonglin1995
Copy link
Contributor

@chuasonglin1995 chuasonglin1995 commented Jan 9, 2025

Relates to

N/A

Risks

Low risk. Did not change functionality. Mostly cleaning up.

Background

What does this PR do?

  • [Improvement]: Added suppressInitialMessage for webSearch Action. If not the conversation would have two messages
  • [Improvement]: Websearch plugin was created in the early ages, so it did not follow the standard that was set. Plugins should be created with folders - /actions, /evaluators etc

Documentation changes needed?

Not required

Testing

Screenshot 2025-01-09 at 10 34 08 PM

Discord username

--> song_45935

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chuasonglin1995! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@chuasonglin1995 chuasonglin1995 changed the base branch from main to develop January 9, 2025 14:29
@tcm390
Copy link
Collaborator

tcm390 commented Jan 9, 2025

Hello @chuasonglin1995. I just tested it, and moving it to the actions folder looks good, but it seems like you forgot to push the code related to suppressInitialMessage?

@odilitime odilitime changed the title Minor Improvement: Add suppressInitialMessage to webSearch Action feat: Minor Improvement: Add suppressInitialMessage to webSearch Action Jan 10, 2025
@chuasonglin1995
Copy link
Contributor Author

chuasonglin1995 commented Jan 12, 2025

@tcm390 hey thanks for the catch!
I have added suppressInitialMessage now. Opps. Somehow it was excluded as i pushed

@chuasonglin1995
Copy link
Contributor Author

Closing this in favour of #2195
I'm removing tavily from core, and converting it into webSearchService

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants