Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing README translations into a dedicated i18n directory structure #2148

Closed
wants to merge 2 commits into from

Conversation

0xnogo
Copy link
Contributor

@0xnogo 0xnogo commented Jan 11, 2025

Relates to

Reorganizing README translations into a dedicated i18n directory structure

Risks

Low - This is primarily a documentation organization change that:

  • Updates file paths for translations
  • Updates GitHub workflow output paths
  • No code functionality changes

Background

What does this PR do?

  1. Creates a new i18n/readme/ directory structure for README translations
  2. Updates the main README.md translation links to point to the new directory
  3. Updates the GitHub workflow to output translations to the new directory
  4. Improves project root directory organization

What kind of change is this?

Improvements (reorganization of existing documentation structure)

Documentation changes needed?

My changes require a change to the project documentation:

  • Updated all translation links in main README.md
  • Updated GitHub workflow configuration for translation generation
  • Created new directory structure for translations

Testing

Where should a reviewer start?

  1. Check the updated README.md translation links
  2. Verify the GitHub workflow configuration changes
  3. Ensure translations are being generated in the correct directory

Detailed testing steps

  1. Run the README translation workflow
  2. Verify translations are generated in i18n/readme/ directory
  3. Verify all links in main README.md work correctly
  4. Check that the commit action still works with the new file paths

Deploy Notes

After merging:

  1. The next translation workflow run will create the i18n/readme directory if it doesn't exist
  2. All new translations will be generated in the new directory structure

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0xnogo! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!

@0xnogo 0xnogo changed the title Ng/move-readmes Reorganizing README translations into a dedicated i18n directory structure Jan 11, 2025
@0xnogo 0xnogo changed the base branch from main to develop January 11, 2025 08:59
@0xnogo 0xnogo changed the base branch from develop to main January 11, 2025 09:59
@0xnogo 0xnogo closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant