-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nft collections getownednfts createlisting getfloorlistings #2189
Closed
IkigaiLabsETH
wants to merge
93
commits into
elizaOS:develop
from
IkigaiLabsETH:feature/nft-collections-getownednfts
Closed
feat: nft collections getownednfts createlisting getfloorlistings #2189
IkigaiLabsETH
wants to merge
93
commits into
elizaOS:develop
from
IkigaiLabsETH:feature/nft-collections-getownednfts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice - Add comprehensive createListing method for Reservoir API - Include parameter validation and default values - Implement error handling and performance monitoring - Generate marketplace URL for listed token
…Service - Add comprehensive getFloorListings method for Reservoir API - Support sorting by price and rarity - Implement detailed error handling and performance monitoring - Transform API response to standardized format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Risks
Background
What does this PR do?
Implements three key methods in the ReservoirService for NFT collections:
getOwnedNFTs
: Fetch NFTs owned by a specific addresscreateListing
: Create a new NFT listing on Reservoir marketplacegetFloorListings
: Retrieve floor listings for a specific collectionWhat kind of change is this?
Documentation changes needed?
My changes require a change to the project documentation.
Testing
Where should a reviewer start?
packages/plugin-nft-collections/src/services/reservoir.ts
Detailed testing steps
Unit Tests
getOwnedNFTs
returns correct NFT data structurecreateListing
with various input parametersgetFloorListings
sorting and filteringIntegration Tests
Manual Verification
Additional Notes