-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add openai env to smokeTests #2472
chore: add openai env to smokeTests #2472
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the GitHub Actions workflow for smoke tests, focusing on enhancing the dependency management and caching strategy. The workflow now uses a Node.js 23 container and implements a more robust caching mechanism for pnpm dependencies. The changes aim to optimize the CI/CD process by explicitly defining cache paths and utilizing the latest caching action. Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/smoke-tests.yml (1)
18-25
: Optimize cache configurationThe caching strategy could be improved:
- Consider caching only the root node_modules
- Add more specific restore-keys for better fallback
path: | ~/.pnpm-store - **/node_modules + node_modules key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }} restore-keys: | ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }} ${{ runner.os }}-pnpm-
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/smoke-tests.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: integration-tests
- GitHub Check: smoke-tests
🔇 Additional comments (2)
.github/workflows/smoke-tests.yml (2)
13-14
: Consider using Node.js LTS versionNode.js 23 is not an LTS release and will reach EOL in June 2024. Consider using
node:20-bullseye
for better stability.
27-30
: Verify pnpm version compatibilityThe pinned pnpm version looks good, but let's verify it matches project requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did this if i broke everything its my fault
Reverts #2459