Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zod should be a devdependency of the anthropic and openai packages #294

Closed

Conversation

tebayoso
Copy link

Relates to:

No specific issue linked, but this change relates to package dependency updates.

Risks

Background

What does this PR do?

This PR adds Zod as a dev dependency for the openAI and Anthropic packages. Zod is a TypeScript-first schema validation library used to ensure data integrity and correctness in various API requests.

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

The reviewer should start by verifying that the devDependencies section in package.json includes Zod. Additionally, they should check if the existing functionality is unaffected by the change.

Detailed testing steps

  • Run npm install or yarn install to ensure Zod is correctly installed as a dev dependency.
  • Check if the package version of Zod is correctly listed and the project builds without issues.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
}
}
},
"packageManager": "pnpm@7.33.7+sha512.7afe2410642b39c698df46da4ce5c7231a5cce360698d69f8cf8f42257d40b3e43f231053b07b8de849fd4ffbf4a71ff57b835137777a352388f3d3da747200e"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be here - pnpm 7 is super old

@tebayoso tebayoso closed this Nov 14, 2024
@tebayoso
Copy link
Author

Sorry this PR was intented to my fork as it is still a wip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants