Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure unique instances for each Service subclass using Map #332

Closed
wants to merge 1 commit into from
Closed

fix: ensure unique instances for each Service subclass using Map #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,15 +503,17 @@ export interface IMemoryManager {
}

export abstract class Service {
private static instance: Service | null = null;
private static instances: Map<any, Service> = new Map();
static serviceType: ServiceType;

public static getInstance<T extends Service>(): T {
if (!Service.instance) {
// Use this.prototype.constructor to instantiate the concrete class
Service.instance = new (this as any)();
if (!Service.instances.has(this)) {
Service.instances.set(
this,
new (this as unknown as { new (): T })()
);
}
return Service.instance as T;
return Service.instances.get(this) as T;
}
}

Expand Down