discord voice #338
discord voice #338
Conversation
… a templates file for reusability
| @@ -88,108 +87,6 @@ export type InterestChannels = { | |||
| }; | |||
| }; | |||
|
|
|||
| const discordShouldRespondTemplate = | |||
There was a problem hiding this comment.
@tcm390discordShouldRespondTemplate and discordMessageHandlerTemplate were moved to templates.ts, but there are still remnants of similar templates being imported and used in messages.ts and voice.ts. Ensure all references are consistently updated to prevent confusion or inconsistent behavior.
There was a problem hiding this comment.
Thank you for the review! I’m not entirely sure what you mean by "similar templates," as I didn’t see any others explicitly named as templates. However, I did notice some export functions in messages.ts and voice.ts, so I moved them to utils.ts for better organization. Could you confirm if that aligns with what you were referring to?
There was a problem hiding this comment.
@tcm390 Thanks for making those changes. This looks good to me!
| } | ||
| ); | ||
|
|
||
| console.log("responseMemories: ", responseMemories); |
There was a problem hiding this comment.
@tcm390 There is a lot of logging (console.log) throughout the code, which could flood the console in a production environment. It would be better to introduce a more sophisticated logging mechanism that allows setting log levels (e.g., info, debug, error).
packages/client-discord/src/voice.ts
Outdated
| name, | ||
| userName | ||
| ); | ||
| }, DEBOUNCE_TRANSCRIPTION_THRESHOLD); |
There was a problem hiding this comment.
@tcm390 There is a potential risk in the way voice transcriptions are handled, where intermittent silence may cause loss of transcription progress. You might want to ensure the transcription buffer persists until a clear "end of input" state is detected, rather than relying solely on timeouts.
There was a problem hiding this comment.
Thanks for pointing out! Could you elaborate further on what you thought? I cannot to think of a better way to implement it and would appreciate your insights.
There was a problem hiding this comment.
Hey @tcm390, just to clarify, my earlier comment was more of a suggestion to ensure there are no potential issues with the implementation. I don't actually have a concrete idea on how to go about solving this. It was just something that came to mind, and I wanted to flag it in case it helps.
join specific channel id
|
can you fix conflicts? |
| @@ -23,304 +19,33 @@ import { | |||
| UUID, | |||
| } from "@ai16z/eliza/src/types.ts"; | |||
| import { stringToUuid } from "@ai16z/eliza/src/uuid.ts"; | |||
There was a problem hiding this comment.
remove fulll imports from eveyrwhere - /src/uuid.ts
|
Closing this PR due to too many conflicts. I’ll create a new PR with a clean base to address the issues. |
related: #244
This PR aims to improve and fix the Discord bot's voice functionality and enhance the code structure for better usability.
1. Fix Bot Voice Singleton Issue
Resolved an issue where the bot's voice functionality failed because the service instance was shared as a singleton across different services. Introduced a Map to ensure each service type has its own singleton instance. This guarantees only one instance of each subclass is created and reused.
2. Add shouldRespond Function
Added a shouldRespond function for the bot's voice feature to control when the bot should respond to user voice inputs.
3. Refactor Transcription Process
Refactored the transcription process by adding a debounce function, ensuring voice messages are processed only when silence is detected.
4. Enable Bot to Respond to Text Messages in Voice Channels
Updated the bot to handle text messages sent in voice channels.
5. Move Template Functions to templates.ts
Relocated template-related functions to a new templates.ts file for reusability in message.ts and voice.ts.
6. Add Optional DISCORD_VOICE_CHANNEL_ID in .env
Introduced a new constant, DISCORD_VOICE_CHANNEL_ID, in the .env file to allow users to specify a voice channel the bot should join.
7. Implemented Audio Playback Interrupt Mechanism
Add a sliding window buffer that monitors the audio volume while the agent is speaking. If the average volume of the user's audio exceeds the defined threshold, it indicates active speaking. When active speaking is detected, stop the agent's current audio playback to avoid overlap.