Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add services from plugins #523

Closed

Conversation

0xFlicker
Copy link
Contributor

Relates to:

n/a

Risks

low to medium. anyone using the node plugin and not loading these services would. this could cause errors? but probably stuff that didn't work starts working

Background

Spun up an eliza bot from eliza-starter (which I also separetly have some updates for)

What does this PR do?

Noticed that for the nodePlugin, the services it defines are not available from the agent runtime when calling getService. This change made it so that nodePlugin automatically brings in these services and the associated actions worked for me: https://github.com/ai16z/eliza/blob/main/packages/plugin-node/src/index.ts#L19-L25

What kind of change is this?

Bug fix

Documentation changes needed?

None, eliza-starter and other nodePlugin consumers should just "work better"

Testing

Where should a reviewer start?

Example code such as https://github.com/ai16z/eliza/blob/main/docs/docs/packages/agent.md should work as expected

Detailed testing steps

@ponderingdemocritus
Copy link
Contributor

this is already being done - not sure why this needs to be here

@0xFlicker
Copy link
Contributor Author

this is already being done - not sure why this needs to be here

sorry, wasn't on the most recent codebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants