fix(plugin-evm): base LiFi class inheritance #991
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
None
Risks
Low, simple refactoring + removal of an unused parameter (mismatching type).
Background
What does this PR do?
SwapAction
andBridgeAction
, both of which use the LiFi SDK, to inheritBaseLifiAction
, which de-duplicates the constructor for the two actions.this.config
fromexecuteRoute
in Swap & Bridge actions, as the type (SDKOptions
) and values ofthis.config
do not match and are not intended to be used inexecuteRoute
, which expects hooks via the typeExecutionOptions
..gitignore
What kind of change is this?
SDKConfig
=/=ExecutionOptions
)Testing
Where should a reviewer start?
Does not change the existing logic of the plugin-evm.
Detailed testing steps
None