Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding tests. changed files actions.test.ts, messages.test.ts, models.test.ts #998

Merged
merged 4 commits into from
Dec 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 101 additions & 67 deletions packages/core/src/tests/actions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,7 @@ import {
formatActionNames,
formatActions,
} from "../actions";
import {
Action,
HandlerCallback,
IAgentRuntime,
Memory,
State,
} from "../types";
import { Action } from "../types";

describe("Actions", () => {
const mockActions: Action[] = [
Expand All @@ -25,98 +19,138 @@ describe("Actions", () => {
content: { text: "Hi {{user1}}!", action: "wave" },
},
],
[
{ user: "user1", content: { text: "Hey {{user2}}, how are you?" } },
{ user: "user2", content: { text: "I'm good {{user1}}, thanks!" } },
],
],
similes: [],
handler: function (
_runtime: IAgentRuntime,
_message: Memory,
_state?: State,
_options?: { [key: string]: unknown },
_callback?: HandlerCallback
): Promise<unknown> {
throw new Error("Function not implemented.");
},
validate: function (
_runtime: IAgentRuntime,
_message: Memory,
_state?: State
): Promise<boolean> {
throw new Error("Function not implemented.");
},
similes: ["say hi", "welcome"],
handler: async () => { throw new Error("Not implemented"); },
validate: async () => { throw new Error("Not implemented"); },
},
{
name: "farewell",
description: "Say goodbye",
examples: [
[
{ user: "user1", content: { text: "Goodbye {{user2}}!" } },
{ user: "user2", content: { text: "Bye {{user1}}!" } },
],
],
similes: ["say bye", "leave"],
handler: async () => { throw new Error("Not implemented"); },
validate: async () => { throw new Error("Not implemented"); },
},
Comment on lines +41 to +43
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably implement these and test then properly in a follow up PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait! :)

{
name: "help",
description: "Get assistance",
examples: [
[
{ user: "user1", content: { text: "Can you help me {{user2}}?" } },
{
user: "user2",
content: { text: "See you later {{user1}}!" },
content: { text: "Of course {{user1}}, what do you need?", action: "assist" }
},
],
],
similes: [],
handler: function (
_runtime: IAgentRuntime,
_message: Memory,
_state?: State,
_options?: { [key: string]: unknown },
_callback?: HandlerCallback
): Promise<unknown> {
throw new Error("Function not implemented.");
},
validate: function (
_runtime: IAgentRuntime,
_message: Memory,
_state?: State
): Promise<boolean> {
throw new Error("Function not implemented.");
},
similes: ["assist", "support"],
handler: async () => { throw new Error("Not implemented"); },
validate: async () => { throw new Error("Not implemented"); },
},
];

describe("composeActionExamples", () => {
it("should generate the correct number of examples", () => {
const result = composeActionExamples(mockActions, 1);
const exampleLines = result
.split("\n")
.filter((line) => line.length > 0);
expect(exampleLines.length).toBe(2); // Each example has 2 messages
it("should generate examples with correct format", () => {
const examples = composeActionExamples(mockActions, 1);
const lines = examples.trim().split("\n");
expect(lines.length).toBeGreaterThan(0);
expect(lines[0]).toMatch(/^user\d: .+/);
});

it("should replace user placeholders with generated names", () => {
const examples = composeActionExamples(mockActions, 1);
expect(examples).not.toContain("{{user1}}");
expect(examples).not.toContain("{{user2}}");
});

it("should handle empty actions array", () => {
const examples = composeActionExamples([], 5);
expect(examples).toBe("");
});

it("should replace placeholder names with generated names", () => {
const result = composeActionExamples(mockActions, 1);
expect(result).not.toContain("{{user1}}");
expect(result).not.toContain("{{user2}}");
it("should handle count larger than available examples", () => {
const examples = composeActionExamples(mockActions, 10);
expect(examples.length).toBeGreaterThan(0);
});
});

describe("formatActionNames", () => {
it("should format action names correctly", () => {
const result = formatActionNames(mockActions);
const names = result.split(", ").sort();
expect(names).toEqual(["farewell", "greet"].sort());
const formatted = formatActionNames([mockActions[0], mockActions[1]]);
expect(formatted).toMatch(/^(greet|farewell)(, (greet|farewell))?$/);
});

it("should handle single action", () => {
const formatted = formatActionNames([mockActions[0]]);
expect(formatted).toBe("greet");
});

it("should return empty string for empty array", () => {
const result = formatActionNames([]);
expect(result).toBe("");
it("should handle empty actions array", () => {
const formatted = formatActionNames([]);
expect(formatted).toBe("");
});
});

describe("formatActions", () => {
it("should format actions with descriptions correctly", () => {
const result = formatActions(mockActions);
const formattedActions = result.split(",\n").sort();
expect(formattedActions).toEqual(
["farewell: Say goodbye", "greet: Greet someone"].sort()
);
it("should format actions with descriptions", () => {
const formatted = formatActions([mockActions[0]]);
expect(formatted).toBe("greet: Greet someone");
});

it("should include commas and newlines between multiple actions", () => {
const formatted = formatActions([mockActions[0], mockActions[1]]);
const parts = formatted.split(",\n");
expect(parts.length).toBe(2);
expect(parts[0]).toMatch(/^(greet|farewell): /);
expect(parts[1]).toMatch(/^(greet|farewell): /);
});

it("should handle empty actions array", () => {
const formatted = formatActions([]);
expect(formatted).toBe("");
});
});

describe("Action Structure", () => {
it("should validate action structure", () => {
mockActions.forEach(action => {
expect(action).toHaveProperty("name");
expect(action).toHaveProperty("description");
expect(action).toHaveProperty("examples");
expect(action).toHaveProperty("similes");
expect(action).toHaveProperty("handler");
expect(action).toHaveProperty("validate");
expect(Array.isArray(action.examples)).toBe(true);
expect(Array.isArray(action.similes)).toBe(true);
});
});

it("should validate example structure", () => {
mockActions.forEach(action => {
action.examples.forEach(example => {
example.forEach(message => {
expect(message).toHaveProperty("user");
expect(message).toHaveProperty("content");
expect(message.content).toHaveProperty("text");
});
});
});
});

it("should return empty string for empty array", () => {
const result = formatActions([]);
expect(result).toBe("");
it("should have unique action names", () => {
const names = mockActions.map(action => action.name);
const uniqueNames = new Set(names);
expect(names.length).toBe(uniqueNames.size);
});
});
});
Loading
Loading