add safe file writer #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* log warn if waiting to obtain the lock * retry renaming & log warn when 'finalizing' a safe write
* add func 'LockCount' to namedLocks
* add note
* discard previous implementation
elv-nate
previously approved these changes
Jul 23, 2024
There was a problem hiding this comment.
LGTM. This seems robust, even though I do think it could be a good idea to add randomness so that multiple temp files can exist concurrently, as this implementation could result in partial files if multiple writers use a safe writer, which isn't necessarily the best behavior.
lukseven
reviewed
Jul 25, 2024
There's no specific reader: opening the file and reading from it gives the last successful version of it. |
elv-nate
approved these changes
Jul 31, 2024
lukseven
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add safe file writing using implementation taken from https://github.com/google/renameio.
Given the potential performance impact, this implementation allows to by-pass the call to
fsync.