Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadAdmin and WriteAdmin grants #55

Closed
wants to merge 1 commit into from
Closed

Conversation

elv-nate
Copy link
Contributor

No description provided.

@elv-nate elv-nate self-assigned this Dec 18, 2024
Copy link
Collaborator

@elv-gilles elv-gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too hot with that change (but not opposed):

Originally we had:

	Create    Grant // allow creation of an item
	Access    Grant // allow to know that an item exist, e.g. in a 'list'
	Read      Grant // allow to read an item
	Update    Grant // allow to modify an item

where each of these 'grants' are used on specific sub-interfaces of the auth context:

type AuthContext interface {
	Space() Space
	Lib() Lib
	Q() Q
...

Then, following some emergency, we added:

	ReadCrypt Grant // read from content crypt

whereas we instead should have been using a Read grant on a Crypt interface of the auth context.

So - same here - we should have an 'Admin' interface on the auth context and use the existing grants.

@elv-nate elv-nate closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants