Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sliceutil.First() & sliceutil.Last(), add missing unit test #56

Merged
merged 1 commit into from
Dec 19, 2024
Merged

add sliceutil.First() & sliceutil.Last(), add missing unit test #56

merged 1 commit into from
Dec 19, 2024

Conversation

lukseven
Copy link
Collaborator

No description provided.

elv-nate
elv-nate approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@elv-nate elv-nate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you can add a case for floating point NaN, but I don't think it's necessary. Otherwise LGTM.

@lukseven lukseven merged commit c418697 into master Dec 19, 2024
1 check passed
@lukseven lukseven deleted the sliceutil-additions branch December 19, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elv-nate elv-nate elv-nate approved these changes

@elv-gilles elv-gilles Awaiting requested review from elv-gilles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukseven @elv-nate