implement read trait for assets for full reader functionality #24
+229
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukseven
reviewed
Jan 8, 2025
src/bccontext_fabric_io.rs
Outdated
|
|
||
| use std::io::{ErrorKind, Read, SeekFrom}; | ||
|
|
||
| pub struct FabricSteamReader<'a> { |
There was a problem hiding this comment.
I hope this is just a typo...
Suggested change
| pub struct FabricSteamReader<'a> { | |
| pub struct FabricStreamReader<'a> { |
elv-nate
approved these changes
Jan 13, 2025
| } | ||
|
|
||
| impl std::io::Seek for FabricStreamWriter<'_> { | ||
| fn seek(&mut self, pos: SeekFrom) -> Result<u64, std::io::Error> { |
| /// byte slice of the read stream | ||
| /// [Example](https://github.com/eluv-io/elv-wasm/blob/019b88ac27635d5022c2211751f6af5957df2463/samples/objtar/src/lib.rs#L112) | ||
| /// | ||
| pub fn read_stream_chunked(&'a self, stream_to_read: String, chunk_size: usize) -> CallResult { |
There was a problem hiding this comment.
Document on read_stream that setting a size of 0 results in the entire stream being read into memory at once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.