Emacs 29 build fix #234
Merged
Emacs 29 build fix #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs090218
approved these changes
Aug 3, 2024
|
Hmm... I don't see any error in the previous build https://github.com/emacsorphanage/git-gutter/actions/runs/8997480781. 🤔 |
|
I don't know if it's MacOS specific, but it gives me an error, and it actually makes sense that it does, since global-linum-mode is not defined in v29.* And again, there are two occurrences of that var in the project, first one (line 533) is checked correctly and doesn't throw any errors, while the one I added null check was used with assumption it is defined while it's not always is. Tested with Emacs v29.4 |
|
Make sense to me! |
jcs090218
approved these changes
Aug 30, 2024
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build issues on Emacs 29+, due to the use of a undefined var global-linum-mode
Resolves #226, resolves #229