forked from robotframework/SeleniumLibrary
-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Initial modeling of a separate finder class with examples
- Created base Finder class which has placeholders for find and pre_find_action methods. Also has a couple utility methods. Still need to figure out a couple shared methods from the old ElementFinder class. - Created (Element)Finder class which would allow for a list of (element)finders instead of just one. This is the central key to be able to look, for example, both in the ShadowDOM and in the regular DOM. This might not be the final model for the list but thought I would start with a iterative class. - Also I would really like to use the ElementFinder name for this Finder class as it better describes the very specific function of finding an element. And then rename the original ElementFinder to something more generic. Having difficulty though trying to figure out that generic name .. something about both parsing locators strings and finding the elements. - Copied/Moved core find method into the DefaultFinder class. - Made a rough model for a separate Strategy class. Not sure if this is the right model for this due to reuse across several places I think this might be the way to go. I am still trying to figure out if all these class need to be ContextAware. Overall though this seems to be a good rough start ..
- Loading branch information
Showing
1 changed file
with
153 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters