Skip to content

[DNM] Integration branch for Kotlin OTel API #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

fractalwrench
Copy link
Contributor

Goal

Integration branch for using the Kotlin OTel API.

@fractalwrench fractalwrench requested a review from a team as a code owner May 1, 2025 09:33
Copy link
Contributor

github-actions bot commented May 1, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 82.71605% with 28 lines in your changes missing coverage. Please review.

Project coverage is 85.47%. Comparing base (3396e1d) to head (eb9c77f).

Files with missing lines Patch % Lines
...oid/embracesdk/internal/otel/payload/SpanMapper.kt 38.46% 4 Missing and 12 partials ⚠️
...d/embracesdk/internal/otel/KotlinApiConversions.kt 61.53% 2 Missing and 3 partials ⚠️
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt 50.00% 0 Missing and 2 partials ⚠️
...mbracesdk/internal/otel/spans/OtelSpanStartArgs.kt 90.00% 1 Missing and 1 partial ⚠️
...id/embracesdk/internal/otel/impl/EmbSpanBuilder.kt 87.50% 0 Missing and 1 partial ⚠️
.../embracesdk/internal/otel/spans/SpanServiceImpl.kt 80.00% 0 Missing and 1 partial ⚠️
...internal/otel/spans/UninitializedSdkSpanService.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
- Coverage   85.61%   85.47%   -0.15%     
==========================================
  Files         465      467       +2     
  Lines       10381    10416      +35     
  Branches     1522     1532      +10     
==========================================
+ Hits         8888     8903      +15     
- Misses        836      853      +17     
- Partials      657      660       +3     
Files with missing lines Coverage Δ
...racesdk/internal/arch/destination/LogWriterImpl.kt 100.00% <100.00%> (ø)
...k/internal/injection/EssentialServiceModuleImpl.kt 100.00% <100.00%> (ø)
...esdk/internal/injection/OpenTelemetryModuleImpl.kt 96.20% <100.00%> (+0.20%) ⬆️
...internal/capture/startup/AppStartupTraceEmitter.kt 86.05% <100.00%> (ø)
...e/android/embracesdk/internal/otel/impl/EmbSpan.kt 96.66% <100.00%> (ø)
...android/embracesdk/internal/otel/impl/EmbTracer.kt 100.00% <100.00%> (ø)
...ce/android/embracesdk/internal/otel/sdk/OtelExt.kt 75.00% <100.00%> (-15.00%) ⬇️
...oid/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt 100.00% <100.00%> (ø)
.../android/embracesdk/internal/otel/sdk/TracerExt.kt 100.00% <100.00%> (+13.63%) ⬆️
...d/embracesdk/internal/otel/spans/EmbraceSdkSpan.kt 100.00% <ø> (ø)
... and 14 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants