Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap iOS code for safety #31

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Wraps calls to the Embrace iOS SDK in a utility function that checks whether Embrace is started before attempting to make a call.

Testing

Ran the example app with/without the Embrace SDK started.

@fractalwrench fractalwrench requested a review from a team as a code owner February 13, 2025 14:00
Copy link

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ArielDemarco ArielDemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 02d8cc6 into use-correct-span-id Feb 14, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants