Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into ts-migration #2816

Merged
merged 13 commits into from
Jul 10, 2022
Merged

Conversation

srmagura
Copy link
Contributor

dtslint is probably going to fail on this. I will fix it in a separate PR so that this one is just a pure merge.

Andarist and others added 13 commits May 30, 2022 16:56
* Update `@types/react`

* Dedupe `@types/react`

* Add changeset
* Use @definitelytyped/dtslint instead of the unmaintained dtslint

* Remove dtslint matrix strategy from main github workflow
* Remove all traces of Preact from the repository

* Revert is-prop-valid changes and add comment

* Update snapshot

* Remove changeset for changes that got reverted
…uldForwardProp` (emotion-js#2333)

* chore(style): let StyledOptions generic argument be optional

* chore(native): let StyledOptions generic argument be optional

* test(types): add tests for StyledOptions iface

* feat(types): add keys assertion for StyledOptions generic

* fix(styled): add StyledOptions type to CreateStyledComponent call signature

fixes emotion-js#2333 (comment)

* test(styled): check type StyledOpts for composite component

* test(styled): revert erroneous changes

* test(styled): clarify StyledOptsBroken test case

* test: refactor `styledOptions` generics tests

* test: add more tests for StyledOptions

* test: linting

* test: tweak ups

* feat: expose FilteringStyledOptions

* fix: expost `FilteringStyledOptions` from native, tweak up some tests, add some comments

* chore: use consistent default props type for both StyledOptions and FilteringStyledOptions

* chore: snap emotion-js#3

* styled.shouldForwardProp: require prop to be a string

* Add PropertyKey->string changesets

* Remove redundant `compilerOptions`

* make `shouldForwardProp` always contravariant

* Type fixes

* Tweak `FilteringStyledOptions` and `StyledOptions` interfaces

* Change `Props` constraint

* Tweak type-level tests around `shouldForwardProp`

* add changesets

Co-authored-by: Sam Magura <srmagura@gmail.com>
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* jest: Allow @types/jest version 28+

* Update packages/jest/package.json

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
…s#2664)

* [wip] Best practices

* [wip] Best practices done except for editing

* Best practices / for library authors EDITS

* Best practices: add CSS variables section

* Best practices: Un-opinionify the sharing styles section

* Edits to best-practices doc

* Make Performance its own docs page

* Edit the For Library Authors page

* Add note about peerDependencies to for-library-authors
* Fix grammar in package-summary.mdx

Fixed double `which` and converted `customise` to `customize` to be consistent with this PR: emotion-js#1870

* fix: another customize fix
@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2022

🦋 Changeset detected

Latest commit: 8c6ad60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/jest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c6ad60:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #2816 (8c6ad60) into ts-migration (8ed0042) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
packages/jest/src/matchers.js 97.43% <100.00%> (+0.13%) ⬆️

@srmagura srmagura merged commit 95726a9 into emotion-js:ts-migration Jul 10, 2022
@srmagura srmagura deleted the ts-merge-0710 branch July 10, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants