Make annotation for methods
more permissive
#2903
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The type annotation for
methods
in theRoute
constructor restricts the input to lists of strings when it can accept any iterable. Themethods
on theRoute
itself are stored as a set.I had the issue when I was trying to build new routes from other preexisting routes:
I changed the annotation to
Collection
, though the current implementation would work with anyIterable
.Collection
allows lists, sets, tuples, andIterable
would also allow generators. Let me know what you prefer.Checklist