cleanup

Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com>
envoyproxy · Jan 18, 2025 · 25aa2ab · 25aa2ab
1 parent 3463d28
commit 25aa2ab
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/source/extensions/filters/common/local_ratelimit/local_ratelimit_impl.cc b/source/extensions/filters/common/local_ratelimit/local_ratelimit_impl.cc
@@ -291,7 +291,6 @@ void LocalRateLimiterImpl::onFillTimer() {
   for (const auto& descriptor : descriptors_) {
     descriptor.second->onFillTimer(refill_counter_, share_factor);
   }
-  dynamic_descriptors_.onFillTimer(refill_counter_, share_factor);
 
   fill_timer_->enableTimer(default_token_bucket_->fillInterval());
 }
@@ -426,12 +425,6 @@ DynamicDescriptorMap::getBucket(const RateLimit::Descriptor request_descriptor)
   return nullptr;
 }
 
-void DynamicDescriptorMap::onFillTimer(uint64_t refill_counter, double factor) {
-  for (const auto& pair : user_descriptors_) {
-    pair.second->onFillTimer(refill_counter, factor);
-  }
-}
-
 DynamicDescriptor::DynamicDescriptor(RateLimitTokenBucketSharedPtr token_bucket, uint32_t lru_size,
                                      TimeSource& time_source)
     : parent_token_bucket_(token_bucket), lru_size_(lru_size), time_source_(time_source) {}
@@ -475,13 +468,6 @@ DynamicDescriptor::addOrGetDescriptor(const RateLimit::Descriptor& request_descr
   return result.first->second.first;
 }
 
-void DynamicDescriptor::onFillTimer(uint64_t refill_counter, double factor) {
-  absl::WriterMutexLock lock(&dyn_desc_lock_);
-  for (auto& pair : dynamic_descriptors_) {
-    pair.second.first->onFillTimer(refill_counter, factor);
-  }
-}
-
 } // namespace LocalRateLimit
 } // namespace Common
 } // namespace Filters

diff --git a/source/extensions/filters/common/local_ratelimit/local_ratelimit_impl.h b/source/extensions/filters/common/local_ratelimit/local_ratelimit_impl.h
@@ -31,7 +31,6 @@ class DynamicDescriptor : public Logger::Loggable<Logger::Id::rate_limit_quota>
   ~DynamicDescriptor() = default;
   // add a new user configured descriptor to the set.
   RateLimitTokenBucketSharedPtr addOrGetDescriptor(const RateLimit::Descriptor& request_descriptor);
-  void onFillTimer(uint64_t refill_counter, double factor);
 
 private:
   RateLimitTokenBucketSharedPtr parent_token_bucket_;
@@ -57,7 +56,6 @@ class DynamicDescriptorMap : public Logger::Loggable<Logger::Id::rate_limit_quot
                      DynamicDescriptorSharedPtr dynamic_descriptor);
   // pass request_descriptors to the dynamic descriptor set to get the token bucket.
   RateLimitTokenBucketSharedPtr getBucket(const RateLimit::Descriptor);
-  void onFillTimer(uint64_t refill_counter, double factor);
 
 private:
   bool compareDescriptorEntries(const std::vector<RateLimit::DescriptorEntry>& request_entries,