Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ecds support for composite filter #29289

Merged
merged 99 commits into from
Dec 14, 2023
Merged

add ecds support for composite filter #29289

merged 99 commits into from
Dec 14, 2023

Conversation

ramaraochavali
Copy link
Contributor

@ramaraochavali ramaraochavali commented Aug 28, 2023 •
edited
Loading

Commit Message: add ecds support for composite filter
Additional Description: Currrently ECDS does not support composite filter. This would help to use composite filter for use cases like WASM filters
Risk Level: Low
Testing: Updated
Docs Changes: Updated
Release Notes: Added

@ramaraochavali
api change
7f58fa5 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
Merge remote-tracking branch 'upstream/main' into fix/composite_ecds
496ce96 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
initial impl
4491374 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
wip
23fe05e 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
Merge remote-tracking branch 'upstream/main' into fix/composite_ecds
589608e 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
add basic implementation
27b1279 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
manual tested
07b5e9c 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
add integration test
5f1e3f4 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #29289 was synchronize by ramaraochavali.

see: more, trace.

@ramaraochavali
fix integration test
fc62678 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
fix life time
4f1baf4 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
add debug logs
3de5e18 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
more debug
f176faf 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
more debug
5562c34 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
format
44be019 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
format again
eba6a46 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
move provider manager as class member
822a200 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
enable full test
96851bc 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali ramaraochavali marked this pull request as ready for review August 31, 2023 04:07
@ramaraochavali
Merge remote-tracking branch 'upstream/main' into fix/composite_ecds
9ba258a 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
more debug
6f8659d 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
remove test case
d67f426 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
add test case back and log
b9085fe 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
fix format
6317691 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
more debug logs
8db6396 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
comment dest
b23d5f3 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
hold providers in provider manager
f1abfc4 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
Copy link
Contributor Author

@alyssawilk Can you please approve and merge?

@alyssawilk alyssawilk enabled auto-merge (squash) December 11, 2023 13:13
adisuissa
adisuissa reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@kyessenov kyessenov removed their assignment Dec 11, 2023
@alyssawilk
Copy link
Contributor

I think this needs one more main merge to pass the new CI checks
/wait

@ramaraochavali
Merge remote-tracking branch 'upstream/main' into fix/composite_ecds
850c11a 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
Copy link
Contributor Author

/retest

@ramaraochavali
Merge remote-tracking branch 'upstream/main' into fix/composite_ecds
0f20e76 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@ramaraochavali
Copy link
Contributor Author

@alyssawilk merged main. But coverage for quic seem to fail and buffer integration test is flaky?

@adisuissa
Copy link
Contributor

@alyssawilk merged main. But coverage for quic seem to fail and buffer integration test is flaky?

I've seen the same quic coverage failure in another PR (#31287), not sure if it is flaky or not.

@alyssawilk
Copy link
Contributor

yeah I think @phlax bumped quic coverage last night

@alyssawilk
Copy link
Contributor

/wait on CI
/retest

@ramaraochavali
Merge remote-tracking branch 'upstream/main' into fix/composite_ecds
c9fe117 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@alyssawilk alyssawilk merged commit b4fba1a into envoyproxy:main Dec 14, 2023
55 of 58 checks passed
@ramaraochavali ramaraochavali deleted the fix/composite_ecds branch December 14, 2023 05:21
@wbpcode wbpcode mentioned this pull request Dec 15, 2023
Merged
@jbohanon jbohanon mentioned this pull request Dec 15, 2023
Merged
@tomjzzhang tomjzzhang mentioned this pull request Dec 18, 2023
Merged
wbpcode added a commit to wbpcode/envoy that referenced this pull request Dec 20, 2023
@wbpcode
clean server factory context and partly revert envoyproxy#29289
b7b4281 
Signed-off-by: wbpcode <wbphub@live.com>
@wbpcode wbpcode mentioned this pull request Dec 20, 2023
Merged
wbpcode pushed a commit that referenced this pull request Dec 20, 2023
clean server factory context and partly revert #29289 (#31458)
812a9ac 
* clean server factory context and partly revert #29289

Signed-off-by: wbpcode <wbphub@live.com>

* minor update

Signed-off-by: wbpcode <wbphub@live.com>

---------

Signed-off-by: wbpcode <wbphub@live.com>
mum4k pushed a commit to envoyproxy/nighthawk that referenced this pull request Dec 20, 2023
@tomjzzhang
Update Envoy to b18ea44 (Dec 18, 2023) (#1047)
1969811 
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit.
- Update to .bazelrc to envoyproxy/envoy#31372
- Update source/client/process_impl.cc to support pure virtual function change introduced in envoyproxy/envoy#29289
- Temporarily disable test_gcc target to unblock import. GCC version was updated with new images envoyproxy/envoy#31372 which now fail on various warnings. 

Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
@zirain zirain mentioned this pull request Dec 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxia tyxia tyxia left review comments

@ohadvano ohadvano ohadvano left review comments

@adisuissa adisuissa adisuissa left review comments

@phlax phlax phlax left review comments

@alyssawilk alyssawilk alyssawilk approved these changes

@kyessenov kyessenov kyessenov approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

@yanavlasov yanavlasov Awaiting requested review from yanavlasov yanavlasov is a code owner

Assignees

@adisuissa adisuissa

@alyssawilk alyssawilk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ramaraochavali @kyessenov @ravenblackx @alyssawilk @phlax @adisuissa @ohadvano @tyxia @htuch