Make the limit on HTTP/2 metadata that can be handled configurable #37372
Conversation
|
Hi @jaydunk, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
jaydunk
force-pushed
the
metadata-fix
branch
from
563df63 to
062c1ee
Compare
|
/retest |
|
/assign @yanavlasov |
|
|
||
| // [#not-implemented-hide:] Hiding until Envoy has full metadata support. |
There was a problem hiding this comment.
? Didn't you just implement it? Can you also add a release note?
There was a problem hiding this comment.
The allow_metadata option, which is required for this to work is similarly hidden. It seemed reasonable to me that this should be hidden if other HTTP/2 metadata options are hidden as well. What do you think?
There was a problem hiding this comment.
@mattklein123 have you had a chance to look at this again? What do you think about the above comment?
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
stale
|
Requested changes from author /wait |
|
LGTM please check CI and merge main. /wait |
stream configurable. Signed-off-by: Jay Dunkelberger <jaydunk@google.com>
Signed-off-by: Jay Dunkelberger <jaydunk@google.com>
Signed-off-by: Jay Dunkelberger <jaydunk@google.com>
Signed-off-by: Jay Dunkelberger <jaydunk@google.com>
Signed-off-by: Jay Dunkelberger <jaydunk@google.com>
Signed-off-by: Jay Dunkelberger <jaydunk@google.com>
Commit Message: Make the limit on HTTP/2 metadata configurable. Defaults to the current hardcoded value of 1 MiB.
Additional Description: The value can be configured through a new field on
Http2ProtocolOptionsRisk Level: Low
Testing: Adds a unit test that covers the new logic in MetadataDecoder
Docs Changes: Added to new proto field but kept hidden to be consistent with other H2 metadata configuration
Release Notes: None
Platform Specific Features: None