Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-granular feature flag for request body compression #38098

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

shaoxt
Copy link

@shaoxt shaoxt commented Jan 17, 2025

Proposal

          http_filters:
          - name: envoy.filters.http.compressor
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.compressor.v3.Compressor
              request_direction_config:
                common_config:
                  enabled:
                    default_value: false
                    runtime_key: request_compressor_enabled
                  enable_on_x_header: true

With this new feature flag "enable_on_x_header: true" enabled.

Even through the global feature flag was set to "false", the compressor filter will check the request header
if the request header contains "X-Request-Compression: true", the request body will be compressed.

This will give more fine-granular control for the istio-proxy outbound traffic.

PR for #38097

Commit Message:

Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #38097]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

Hi @shaoxt, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #38098 was opened by shaoxt.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #38098 was opened by shaoxt.

see: more, trace.

ravenblackx and others added 2 commits January 17, 2025 12:38
)

Commit Message: Remove incorrect/outdated doc for explicit_http_config
Additional Description: Per envoyproxy#38064, this docstring became incorrect with
envoyproxy#14362 so should be removed.
Risk Level: None, doc-only.
Testing: n/a
Docs Changes: Yes it is.
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
@shaoxt shaoxt force-pushed the enable_on_x_header_38097 branch from 8ec737c to e5d1001 Compare January 17, 2025 20:38
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
@shaoxt shaoxt changed the title Fine feature flag for request body compression Fine-granular feature flag for request body compression Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fine control over the request body compression in compression envoy filter
3 participants