-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine-granular feature flag for request body compression #38098
base: main
Are you sure you want to change the base?
Conversation
Hi @shaoxt, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
) Commit Message: Remove incorrect/outdated doc for explicit_http_config Additional Description: Per envoyproxy#38064, this docstring became incorrect with envoyproxy#14362 so should be removed. Risk Level: None, doc-only. Testing: n/a Docs Changes: Yes it is. Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
8ec737c
to
e5d1001
Compare
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Signed-off-by: Sheldon <shaoxt@gmail.com>
Proposal
With this new feature flag "enable_on_x_header: true" enabled.
Even through the global feature flag was set to "false", the compressor filter will check the request header
if the request header contains "X-Request-Compression: true", the request body will be compressed.
This will give more fine-granular control for the istio-proxy outbound traffic.
PR for #38097
Commit Message:
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #38097]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]