[mobile]Create a real dummy socket option to manage network type hashing #38099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Renjie Tang <renjietang@google.com>
Signed-off-by: Renjie Tang <renjietang@google.com>
RenjieTang
requested review from
RyanTheOptimist,
alyssawilk,
abeyad and
fredyw
as code owners
| return absl::make_optional(std::move(details)); | ||
| } | ||
|
|
||
| bool NetworkTypeSocketOptionImpl::isSupported() const { return optname_.hasValue(); } |
There was a problem hiding this comment.
Given that optname_ appears to be const, does this method always return true?
There was a problem hiding this comment.
You are right. I was cargo culting the socket tagging code.
Now it fixed. It should always return true.
It's quite hard to add an integration test for this. I added a unit test to test on socket option hash generations. |
RyanTheOptimist
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Create a real dummy socket option to manage network type hashing
Additional Description: The previous approach uses IP_TTL and it might cause unwanted behavior in production.
Risk Level: low
Testing: existing tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile only
Runtime guard: envoy_reloadable_features_use_network_type_socket_option