Prefer Set.prototype.values() over .entries()
#131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each iteration value in [`Set.prototype.entries()`][0] is an array of
two identical values:
const mySet = new Set(['a' , 'b', 'c']);
console.log([...mySet.entries()]);
// => [ [ 'a', 'a' ], [ 'b', 'b' ], [ 'c', 'c' ] ]
That's unnecessary for this library, which can just use
[`Set.prototype.values()`][1].
const mySet = new Set(['a' , 'b', 'c']);
console.log([...mySet.values()]);
// => [ 'a', 'b', 'c' ]
This simplifies the code a bit and should result in a small speed
improvement.
[0]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/entries
[1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/values
5 tasks
|
Let me know if there's anything I can do to help this PR along. |
|
This PR has been open for two years. Anything I can do to help get this merged? |
|
sorry this hasn't been merged yet (if I had any power I would), but it did help me out a lot. thanks! |
|
I am wondering why it was entries to begin with, but values should do the same for sets |
|
My guess: it was copied from the code for I don't think it's a runtime compatibility thing because everywhere I ran a quick test on my machine, and this branch checks Sets about 22% faster. See the full code and results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each iteration value in
Set.prototype.entries()is an array of two identical values:That's unnecessary for this library, which can just use
Set.prototype.values().This simplifies the code a bit and should result in a small speed improvement.