Environment variables in tmux options not honoured

[eulersson]

See the issue #1 for full description of what this PR is trying to address.

[eulersson]

@erikw Feel free to tackle this in any way you want... I you want to discard the PR it's OK but some users, specially on macOS might face the issue of not seeing the change reflected because of the wrong variable expansion.

[eulersson]

Thanks for your plugin by the way! It's very nice :)

[ivuorinen]

Just a small typo fix and reformatting for easier reading.

[ivuorinen]

Suggested change

	# `"$HOME/a/b/c"` or else this script needs to sanitize that backslack for the `eval
	# echo `"$theme_path"` to properly expand the environment variables.
	# `"$HOME/a/b/c"` or else this script needs to sanitize that backslack for
	# the `$(eval echo "$theme_path")` to properly expand the environment variables.

Spotted a minor typo, updated the example to reflect the actual code. Otherwise 👍

[erikw]

Thank you, I will need to look in to this more in detail when I have access to my own computer again (it will still take a while, hold on…).

As I showed before, single quotes works fine on my setup:
#1 (comment)

Thus I need to debug this further:)

[erikw]

I had a quick look at the code now as I had a vague memory that I actually added extra code to make sure that environment variables like $HOME will be expanded, which is my config using single quote works (on my machine hehe). And indeed, I found the code:

tmux-dark-notify/scripts/tmux-theme-mode.sh

Lines 47 to 48 in dfa2b45

	# Expand e.g. $HOME
	theme_path=$(eval echo "$theme_path")

While I don't have access to this mac machine at the moment still for a while... maybe you could debug on your machine on why your $HOME is not expanded if you set the config variable with single quotes like in the README example.

One way to do this can be to enable debug mode in bash and log it all to a file and inspect.

Edit https://github.com/erikw/tmux-dark-notify/blob/main/scripts/tmux-theme-mode.sh by inserting these two first lines at the top of the file

set -x
exec 2>/tmp/tmux-dark-notify.log

And after running the script, check the output logged to /tmp/tmux-dark-notify.log. Specifically identify this line and see how it executes on your machine, is the $HOME still not expanded after this line?

tmux-dark-notify/scripts/tmux-theme-mode.sh

Lines 47 to 48 in dfa2b45

	# Expand e.g. $HOME
	theme_path=$(eval echo "$theme_path")