-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to correct math for watt/kilowatt conversion #4816
base: current
Are you sure you want to change the base?
Conversation
1kW = 1000 watts 1 ÷ 1000 = 0.001
WalkthroughThe pull request updates the filter configuration for the Changes
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cookbook/power_meter.rst (1)
99-99
: Update Multiplier Consistency and Comment ClarityThe multiplication factor has been correctly updated to
0.001
to reflect the conversion (i.e. 1 kW equals 1000 W). However, the inline comment still states(1/10000 pulses per kWh)
, which may confuse readers regarding the math behind the conversion. Please update the comment to clearly explain the intended conversion, for example, indicating that the factor0.001
corresponds to dividing by 1000.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cookbook/power_meter.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams
**
: - Do not generate or add any sequence diagrams
cookbook/power_meter.rst
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
That depends on the meter type. There are meters pulsing 10000 times per kWh. |
I see. Maybe the change should be to make that more prominent then |
1kW = 1000 watts
1 ÷ 1000 = 0.001
See Home Assistant Glow config for reference
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rst
when creating new documents for new components or cookbook.