bsp: Update BSPs for using button v4

[espzav]

ESP-BSP Pull Request checklist

• Version of modified component bumped
• CI passing

Change description

• Updated BSPs for using it with button component v4

Updated BSPs to button v4

• esp_bsp_devkit (done in another PR)
• esp_bsp_generic (done in another PR)
• esp_wrover_kit
• esp32_azure_iot_kit
• esp32_c3_lcdkit
• esp32_lyrat
• esp32_p4_function_ev_board (no buttons)
• esp32_s2_kaluga_kit - NOT TESTED ON HW
• esp32_s3_eye
• esp32_s3_korvo_1 - NOT TESTED ON HW
• esp32_s3_korvo_2
• esp32_s3_lcd_ev_board
• esp32_s3_usb_otg
• esp-box-3
• m5dial
• m5stack_core
• m5stack_core_2 (no buttons)
• m5stack_core_s3 (no buttons)

No SD card = RELEASE

• esp32_c3_lcdkit
• esp32_s2_kaluga_kit
• esp32_s3_lcd_ev_board
• m5dial

[github-actions]

Test Results

 17 files  17 suites   5m 53s ⏱️
 68 tests 24 ✅  44 💤 0 ❌
408 runs  24 ✅ 384 💤 0 ❌

Results for commit 3592ac0.

♻️ This comment has been updated with latest results.

[espzav]

@tore-espressif PTAL

[tore-espressif]

@espzav esp_lvgl_port LGTM.

I don't have any of these boards now to test...

Strictly speaking, bump of major version of public component is a breaking change -> we should bump major versions of the BSPs too...
However, looking at the button v4 changes, there are only 2:

• Button creation -> this is handled by BSP
• Register/unregistering of button callback -> this will require users to change their code, if they use these functions

[espzav]

However, looking at the button v4 changes, there are only 2:

I am not sure, if there are real breaking changes:

1. When you are using button v3 with LVGL port --> No breaking changes
2. When you change from v3 to v4 button with LVGL port --> You must make changes
3. In BSPs, there is everything handled inside or in examples --> No breaking changes

[espzav]

And when I am thinking about it, there can be solution for use both version of button in BSPs too. I am not suer, if we want it (add more ifdefs)

[tore-espressif]

And when I am thinking about it, there can be solution for use both version of button in BSPs too. I am not suer, if we want it (add more ifdefs)

I'd prefer supporting only one (the latest) version

[espzav]

I'd prefer supporting only one (the latest) version

OK, should I increase major version of affected BSPs?

[lijunru-hub]

Sorry for the late reply. The custom button can be created using the factory mode of the new button component. You can refer to this file:

[custom_button_test.c](https://github.com/espressif/esp-iot-solution/blob/master/components/button/test_apps/main/custom_button_test.c)

[espzav]

Sorry for the late reply. The custom button can be created using the factory mode of the new button component. You can refer to this file:

[custom_button_test.c](https://github.com/espressif/esp-iot-solution/blob/master/components/button/test_apps/main/custom_button_test.c)

@lijunru-hub Thank you!

[espzav]

@tore-espressif I updated this PR with changes for all BSPs with button v4. PTAL

[lijunru-hub]

LGTM!