Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes gt911 without reset pin (BSP-642) #520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AkaBkn
Copy link
Contributor

@AkaBkn AkaBkn commented Feb 26, 2025

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Please describe your change here

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title fixes gt911 without reset pin fixes gt911 without reset pin (BSP-642) Feb 26, 2025
@espzav
Copy link
Collaborator

espzav commented Mar 18, 2025

I am not sure, if I understand right your changes. But this part of code needs both pins (interrupt + reset). This change is useless from my point of view.

@AkaBkn
Copy link
Contributor Author

AkaBkn commented Mar 19, 2025

its not. without the patch, you can not use this driver without the reset pin (esp_lcd_touch_gt911->config.rst_gpio_num = GPIO_NUM_NC). but devices like the LilyGo T-Deck Plus have the reset pin not connected. with this change you can use the driver on those devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants