ssd1680 support (BSP-643) #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs testing plus validation
Reflects addition of row override, opening door to ssd1680 support
|
|
There was a problem hiding this comment.
@malachib thank you for the PR!
Would it be better if we stored real number of rows in epaper_panel->_rows?
| @@ -14,7 +14,8 @@ | |||
| #define SSD1681_CMD_SWRST 0x12 | |||
| // --- Driver output control | |||
| #define SSD1681_CMD_OUTPUT_CTRL 0x01 | |||
| #define SSD1681_PARAM_OUTPUT_CTRL ((uint8_t[]) {0xc7, 0x00, 0x00}) | |||
| // Chipset wants (total row count - 1) i.e. 250 rows = 249 here | |||
| #define SSD1681_PARAM_OUTPUT_CTRL(rows) ((uint8_t[]) {(rows) & 0xFF, (rows) >> 8, 0x00}) | |||
There was a problem hiding this comment.
Suggested change
| #define SSD1681_PARAM_OUTPUT_CTRL(rows) ((uint8_t[]) {(rows) & 0xFF, (rows) >> 8, 0x00}) | |
| #define SSD1681_PARAM_OUTPUT_CTRL(rows) ((uint8_t[]) {(rows - 1) & 0xFF, (rows - 1) >> 8, 0x00}) |
Comment on lines
+275
to
+276
| (epaper_ssd1681_conf->rows - 1) : (SSD1681_EPD_1IN54_V2_HEIGHT - 1); | ||
| if(epaper_panel->_rows != (SSD1681_EPD_1IN54_V2_HEIGHT - 1) && |
There was a problem hiding this comment.
Suggested change
| (epaper_ssd1681_conf->rows - 1) : (SSD1681_EPD_1IN54_V2_HEIGHT - 1); | |
| if(epaper_panel->_rows != (SSD1681_EPD_1IN54_V2_HEIGHT - 1) && | |
| (epaper_ssd1681_conf->rows) : (SSD1681_EPD_1IN54_V2_HEIGHT); | |
| if(epaper_panel->_rows != (SSD1681_EPD_1IN54_V2_HEIGHT) && |
|
Thank you too for providing the ssd1681 in the first place! I am open to your suggestion. I treated rows as precalculated as an optimization. Subtracts are about as fast as it gets though... Certainly the code is clearer the way you suggest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
Added row override so that ssd1680 may also be used