Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(runner): Fix benchmark results releases #551

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Mar 26, 2025

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

  • I found my issue in CI - new benchmarks was not saved into releases

Reverted (I am not sure with this change):

Copy link

github-actions bot commented Mar 26, 2025

Test Results

 19 files  19 suites   6m 17s ⏱️
 76 tests 26 ✅  50 💤 0 ❌
494 runs  26 ✅ 468 💤 0 ❌

Results for commit 681af2c.

♻️ This comment has been updated with latest results.

@espzav espzav requested a review from tore-espressif March 26, 2025 14:12
@espzav
Copy link
Collaborator Author

espzav commented Mar 26, 2025

@tore-espressif PTAL

@espzav espzav force-pushed the ci/fix_benchmark_release branch from 54e0776 to 89e1d4e Compare March 31, 2025 08:38
@espzav espzav force-pushed the ci/fix_benchmark_release branch from 89e1d4e to e7b3658 Compare April 7, 2025 07:20
@espzav
Copy link
Collaborator Author

espzav commented Apr 7, 2025

I removed change on pull_request to on pull_request_target. Because there can be security risk from forks. I must read about it more and make decision in future.

@espzav espzav force-pushed the ci/fix_benchmark_release branch from e7b3658 to 681af2c Compare April 7, 2025 08:26
@espzav espzav merged commit 5e90db3 into master Apr 7, 2025
39 checks passed
@espzav espzav deleted the ci/fix_benchmark_release branch April 7, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants