Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dependencies.lock files for example projects (AEGHB-941) #118

Open
3 tasks done
francisduvivier opened this issue Jan 7, 2025 · 2 comments
Open
3 tasks done

Comments

@francisduvivier
Copy link

francisduvivier commented Jan 7, 2025

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report

There is no dependency lock files in any of the examples. When I filed this ticket, if you tried to build one of the examples on a fresh environment, the build was already broken because one of the 0.x dependencies had a breaking change.
So it would be helpful to follow the guidance from the espressif docs and check in the dependency lock files.

@github-actions github-actions bot changed the title Please check in dependency lock files for examples Please check in dependency lock files for examples (AEGHB-941) Jan 7, 2025
@francisduvivier francisduvivier changed the title Please check in dependency lock files for examples (AEGHB-941) No dependency lock files for examples (AEGHB-941) Jan 25, 2025
@francisduvivier francisduvivier changed the title No dependency lock files for examples (AEGHB-941) No dependencies.lock files for example projects (AEGHB-941) Jan 25, 2025
@Horion0415
Copy link
Contributor

Sorry, could you please fully describe the issue you encountered? The dependency lock file is generated during compilation.

@francisduvivier
Copy link
Author

Hi @Horion0415 sorry for the late reply. But so the issue that I encountered was this one: ESP32-P4 esp_brookesia_phone example broken because of breaking change in esp_ipa (AEGHB-942) #119

But so I made separate issue here because it would be quite helpful if those lock files that are generated during compilation are also included in git.
This will really help a lot in the future when examples start getting abandoned, or when somebody wants to go back to an older version of the code.

I do realise that I linked the wrong documentation link in my description. Apologies for that, I wanted to refer to the documentation of the dependencies.lock file from Espressif which states:

If your project includes only the ESP Component Registry Dependencies or Git Dependencies, it is recommended to check in the dependencies.lock file to ensure all developers use the same component versions when building locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants