Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-P4 esp_brookesia_phone example broken because of breaking change in esp_ipa (AEGHB-942) #119

Closed
3 tasks done
francisduvivier opened this issue Jan 7, 2025 · 6 comments

Comments

@francisduvivier
Copy link

francisduvivier commented Jan 7, 2025

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.

v5.5-dev-1050-gb5ac4fbdf9 but also on v5.4

Espressif SoC revision.

ESP32-P4 Function_EV_Board V1.4

Operating System used.

macOS

How did you build your project?

Command line with idf.py

If you are using Windows, please specify command line type.

None

Development Kit.

ESP32-P4 Function_EV_Board V1.4

Steps to reproduce.

  1. Fresh checkout of the repo or remove all git-untracked files in examples/esp32-p4-function-ev-board/examples/esp_brookesia_phone
  2. cd examples/esp32-p4-function-ev-board/examples/esp_brookesia_phone
  3. idf.py build

Build Logs.

esp-dev-kits/examples/esp32-p4-function-ev-board/examples/esp_brookesia_phone/managed_components/espressif__esp_video/src/esp_video_isp_pipeline.c:752:23: error: too many arguments to function 'esp_ipa_pipeline_create'
  752 |     ESP_GOTO_ON_ERROR(esp_ipa_pipeline_create(config->ipa_nums, config->ipa_names, &isp->ipa_pipeline),

More Information.

The esp32-p4-function-ev-board/examples/esp_brookesia_phone is broken because of a breaking change in the esp_ipa component.

The esp_ipa component has updated from 0.1.0 to 0.2.0 and there are breaking changes which break this project, but the version of esp_ipa is not specified explicitly and there is no dependency lock so now the example is broken.

Note, I also requested lock files to be added for all examples in #118 which could possibly also solve this already, but for this example specifically, I think the esp_ipa 0.1.0 dependency should better also be added to the idf_component.yml specification since it's used directly in this example project.

I added espressif/esp_ipa: =0.1.0 at the end of my main/idf_component.yml which solves this issue for me.

@github-actions github-actions bot changed the title ESP32-P4 esp_brookesia_phone example broken because of breaking change in esp_ipa ESP32-P4 esp_brookesia_phone example broken because of breaking change in esp_ipa (AEGHB-942) Jan 7, 2025
@intikhabalam12
Copy link

Yes... I was facing the same issue... build process was breaking because of esp:ipa error. I add the following lines in my main/idf_component and it solved it for me.
espressif/esp_ipa:
version: "0.1.*"
@francisduvivier Thanks for the tip

@kylongmu
Copy link

Same error shows:
D:/Develop/Arduino/ESP32P4/esp-dev-kits-master/examples/esp32-p4-function-ev-board/examples/esp_brookesia_phone/managed_components/espressif__esp_video/src/esp_video_isp_pipeline.c:752:53: error: passing argument 1 of 'esp_ipa_pipeline_create' makes pointer from integer without a cast [-Wint-conversion]
752 | ESP_GOTO_ON_ERROR(esp_ipa_pipeline_create(config->ipa_nums, config->ipa_names, &isp->ipa_pipeline),
| ~~~~~~^~~~~~~~~~

@kylongmu
Copy link

espressif/esp_ipa:
version: "0.1.*"

Thanks, you solved this problem.

@Horion0415
Copy link
Contributor

Sorry, this is a compilation error caused by updates to esp_video and related components. We will update and fix this issue later.

@Horion0415
Copy link
Contributor

The compilation issue has been fixed. You can test the latest example.

@francisduvivier
Copy link
Author

francisduvivier commented Jan 25, 2025

Just checked, the esp_brookesia_phone example is indeed building again on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants