Fix for a deadlock startup problem where "port_serial_task" is suspended and never resumed. (IDFGH-14964) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suspended and never resumed. port_serial_task is started with "enable" set to false. Then in main loop it checked if "enable" was false and called vTaskSuspend. Another task, which called mbc_slave_create_serial and mbc_slave_start, may cause that mb_port_ser_enable is called between checking "enable" flag and vTaskSuspend in port_serial_task. As a result, mb_port_ser_enable calls vTaskResume on a non-suspended task. Then control is given back to port_serial_task, which calls vTaskSuspend and stucks in this state forever. Fix is replacing vTaskSuspend and vTaskResume with a semaphore based ulTaskNotifyWait and vTaskNotifyGive. Additionally "enable" flag is checked in while loop instead of "if".
|
|
github-actions
bot
changed the title
|
Thank you for contribution. Looks good for now. I will take a look a bit later to check and apply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port_serial_task is started with "enable" set to false. Then in main loop it checked if "enable" was false and called vTaskSuspend. Another task, which called mbc_slave_create_serial and mbc_slave_start, may cause that mb_port_ser_enable is called between checking "enable" flag and vTaskSuspend in port_serial_task. As a result, mb_port_ser_enable calls vTaskResume on a non-suspended task.
Then control is given back to port_serial_task, which calls vTaskSuspend and stucks in this state forever.
Fix is replacing vTaskSuspend and vTaskResume with a semaphore based ulTaskNotifyWait and vTaskNotifyGive. Additionally "enable" flag is checked in while loop instead of "if".