-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/generate build child pipeline #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for a build child pipeline by enhancing configuration and argument handling for build targets. Key changes include:
- Adding a new setting, extra_default_build_targets, in the CI settings.
- Introducing a helper function _set_args to consolidate and prioritize build-related arguments.
- Updating the get_all_apps function to include a new parameter (compare_manifest_sha_filepath) and streamline its argument handling, including minor renaming in the get_app_dict helper.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
idf_ci/settings.py | Added extra_default_build_targets for specifying additional build targets. |
idf_ci/scripts.py | Introduced _set_args for argument handling and updated get_all_apps to support new build pipeline requirements. |
Comments suppressed due to low confidence (2)
idf_ci/scripts.py:39
- The use of '# type: ignore' suggests potential type compatibility issues when merging default_build_targets with settings.extra_default_build_targets. Consider verifying and reconciling the types to remove the need for type ignoring.
default_build_targets = [*default_build_targets, *settings.extra_default_build_targets] # type: ignore
idf_ci/scripts.py:139
- [nitpick] The naming of the parameter (_cases) and the inner loop variable (_case) is inconsistent with conventional naming patterns. Consider renaming these to 'cases' and 'case' respectively for clarity and consistency.
def get_app_dict(_cases):
|
6ce9707
to
ad473c5
Compare
…on_test_related_apps_filepath` to load apps from txt files
4dc8fe2
to
c67c3a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
c67c3a1
to
4ea3fa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
idf_ci/scripts.py:134
- [nitpick] Consider renaming the loop variable '_t' to a more descriptive name (e.g. 'target_value') to improve clarity.
for _t in target.split(','):
4ea3fa6
to
e739b39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
idf_ci/idf_pytest/scripts.py:69
- [nitpick] The check 'if filter_expr:' may inadvertently skip applying a filter when an empty string is provided. Consider using 'if filter_expr is not None:' to differentiate between an unset filter and an intentionally empty filter.
if filter_expr:
68f972e
to
63dcca1
Compare
63dcca1
to
198050d
Compare
No description provided.