-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/update cmds #1160
Docs/update cmds #1160
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@brianignacio5 hi !
the second notification ask to open sdk editor. I think we don't need double confirmation from user. but no hint at all here. We could add "Build project first" to this notification as well. |
This should be fixed. PTAL again |
@brianignacio5 hi ! Tested under: |
@brianignacio5 hi ! Right click on .csv file in project -> The "NVS Partition Editor" still remains in the old format. |
Updated to new format |
@brianignacio5 hi ! Run ESP-IDF: Configure ESP-IDF extension. Using workspace folder as save settings location (with idf.saveScope). -> still see the dropdown list during installation |
@brianignacio5 hi ! Tested under: Rename NVS Partition Editor and Partition Editor commands names. ✔️ If project hasn't built yet -> try to open Partition Table Editor -> good info message 👍 LGTM 👍 |
Description
This PR address a few different issues:
venv
validation in Setup Wizard.Fixes #1061
Fixes #1086
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: Configure ESP-IDF
extension. Using workspace folder as save settings location (with idf.saveScope).How has this been tested?
Manual testing based on steps above.
Test Configuration:
Checklist