-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIM Integration #1355
base: master
Are you sure you want to change the base?
EIM Integration #1355
Conversation
Download the artifacts for this pull request: |
9c56b92
to
bb63d19
Compare
Pull request has been marked as |
81e61a5
to
356f945
Compare
Pull request has been marked as |
6923783
to
49926a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, great job on the changes!
I've left a few comments, some related to translations, some small modification and some questions.
@@ -70,7 +77,9 @@ export async function configureProjectWithGcov(workspacePath: Uri) { | |||
appTraceGcovEnable === "y"; | |||
|
|||
if (isGcovEnabled) { | |||
return window.showInformationMessage("Code coverage is already enabled in sdkconfig"); | |||
return window.showInformationMessage( | |||
"Code coverage is already enabled in sdkconfig" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not part of the change, but we should use translation here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a new more comprehensive ticket about this VSC-1609
6f950ac
to
2fa7c0f
Compare
0dff1ac
to
b4b38c9
Compare
45689d0
to
4ec0589
Compare
Description
Add initial EIM integration with
eim_idf.json
and command to open URL for IDF-IM-UI download.Type of change
Steps to test this pull request
This PR introduces breaking change to how this extension works.
eim_idf.json
to get ESP-IDF setups in the user environment. If no setups were found, fallback to resolve system environment variables IDF_TOOLS_PATHesp_idf.json
andidf.customExtraVars
["IDF_TOOLS_PATH"]esp_idf.json
. If no setups are found, it will try to use environment variablesIDF_PATH
,IDF_TOOLS_PATH
andIDF_PYTHON_ENV_PATH
to define the current IDF_SETUP. These variables can also be defined inidf.customExtraVars
.ESP-IDF: Doctor Command
.ESP-IDF: Open ESP-IDF Install manager
command which open a URL to download EIM releases."idf.currentSetup"
will be read to load env variables into workspace state of the corresponding esp-idf setup. Example:"idf.currentSetup": "/path/to/esp-idf"
Things to test:
$IDF_TOOLS_PATH/esp_idf.json
) should be listed. When one esp-idf setup is selected, settings are saved in current workspace folder in workspace state and a setting"idf.currentSetup"
will be saved pointing to selected esp-idf."idf.currentSetup"
will be saved pointing to selected esp-idf.How has this been tested?
Manual testing of scenarios described above.
Test Configuration:
Checklist