Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1540]Remove efuse validation for JTAG #1382

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

radurentea
Copy link
Collaborator

Description

Removing extra validation that was added with the enhancement of flash encryption in 1.9.0 release. The validation was checking efuse to see if JTAG is disabled on the board, by doing this the board was being reset to enter second bootloader. This was causing a timing issue with JTAG flashing.
These types of low level validation needs to be handled by OPENOCD.

Fixes #1368

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Flash a project using JTAG flash method.

How has this been tested?

As described above

Test Configuration:

  • ESP-IDF Version: 5.3.2
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

Copy link

github-actions bot commented Jan 9, 2025

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Jan 9, 2025
@radurentea radurentea self-assigned this Jan 9, 2025
@radurentea radurentea added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Jan 9, 2025
@radurentea radurentea changed the title Remove efuse validation for JTAG [VSC-1540]Remove efuse validation for JTAG Jan 9, 2025
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows and mac.
I was apple to repeatedly flash my ESP32H2 and ESP32S3 targets though JTAG with no errors on both operating systems.
Unfortunately the other targets available do not have a JTAG interface working.

@radurentea radurentea merged commit e86393b into master Jan 20, 2025
6 checks passed
@radurentea radurentea added this to the v1.9.1 milestone Jan 20, 2025
@wormyrocks
Copy link

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JTAG flashing error on 1.9.0 (VSC-1540)
4 participants