Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1604 | VSC-1606 | VSC-1624] use idf py qemu Allow qemu debug monitor #1462

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Mar 10, 2025

Description

This PR modifies the QEMU Debug and monitor implementation to use idf.py qemu instead. This allows to offload the extension to keep track of arguments for QEMU.

Add idf.qemuDebugMonitor to allow start monitor session after debug session and idf.qemuExtraArgs to define additional idf.py qemu arguments.

Fixes #1447
Fixes #1449
Fixes #1473

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Monitor QEMU Device". The monitor should start after loading QEMU.
  2. Set "idf.qemuDebugMonitor": true. Run ESP-IDF: Launch QEMU Debug Session. Observe that the debug session starts and later the monitor will start.
  3. The user can also use "idf.qemuExtraArgs": [] to specify additional QEMU arguments. Some options are --qemu-extra-args <args> or --flash-file <path/to/qemu.bin etc.
  • Expected behaviour:

  • QEMU monitor and debug works as usual.

  • Expected output:

How has this been tested?

Manual testing as described above.

Test Configuration:

  • ESP-IDF Version: 5.2
  • OS (Windows,Linux and macOS): Docker container in Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the v1.10.0 milestone Mar 10, 2025
@brianignacio5 brianignacio5 self-assigned this Mar 10, 2025
Copy link

github-actions bot commented Mar 10, 2025

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@brianignacio5 brianignacio5 added the enhancement New feature or request label Mar 10, 2025
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working the terminal and the arguments passed to the qemu terminal command. Confirmed on Windows and Mac using Docker container.

@Fabricio-ESP Fabricio-ESP changed the title use idf py qemu Allow qemu debug monitor [VSC-1604 | VSC-1606] use idf py qemu Allow qemu debug monitor Mar 13, 2025
@Fabricio-ESP Fabricio-ESP changed the title [VSC-1604 | VSC-1606] use idf py qemu Allow qemu debug monitor [VSC-1604 | VSC-1606 | VSC-1624] use idf py qemu Allow qemu debug monitor Mar 19, 2025
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit d421232 into master Mar 27, 2025
7 checks passed
@brianignacio5 brianignacio5 deleted the enhance/qemu-gdb-monitor branch March 27, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants