-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1604 | VSC-1606 | VSC-1624] use idf py qemu Allow qemu debug monitor #1462
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working the terminal and the arguments passed to the qemu terminal command. Confirmed on Windows and Mac using Docker container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR modifies the QEMU Debug and monitor implementation to use
idf.py qemu
instead. This allows to offload the extension to keep track of arguments for QEMU.Add
idf.qemuDebugMonitor
to allow start monitor session after debug session andidf.qemuExtraArgs
to define additionalidf.py qemu
arguments.Fixes #1447
Fixes #1449
Fixes #1473
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
"idf.qemuDebugMonitor": true
. RunESP-IDF: Launch QEMU Debug Session
. Observe that the debug session starts and later the monitor will start."idf.qemuExtraArgs": []
to specify additional QEMU arguments. Some options are--qemu-extra-args <args>
or--flash-file <path/to/qemu.bin
etc.Expected behaviour:
QEMU monitor and debug works as usual.
Expected output:
How has this been tested?
Manual testing as described above.
Test Configuration:
Checklist