Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1629] fix openocd args order #1482

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

brianignacio5
Copy link
Collaborator

Description

idf.openOcdLaunchArgs are added before idf. openOcdConfigs.

Make sure that if the config file is already in idf.openOcdLaunchArgs it would not be added.

Fixes #1481

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Set idf.openOcdLaunchArgs to some value like ["-c", "set ESP_FLASH_SIZE 0"] and idf. openOcdConfigs should have some value like ["board/esp32-wrover-kit-3.3v.cfg"].

  1. Click on "Start OpenOCD Server"
  2. Execute action. You should see in the ESP-IDF output that the idf.openOcdLaunchArgs arguments are used before idf. openOcdConfigs arguments.
  3. Observe results.
  • Expected behaviour:

idf.openOcdLaunchArgs are added before idf. openOcdConfigs.

  • Expected output:

idf.openOcdLaunchArgs are added before idf. openOcdConfigs.

Test Configuration:

  • ESP-IDF Version: 5.3.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the v1.10.0 milestone Mar 21, 2025
@brianignacio5 brianignacio5 self-assigned this Mar 21, 2025
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@Fabricio-ESP Fabricio-ESP changed the title fix openocd args order [VSC-1629] fix openocd args order Mar 25, 2025
Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed correct order of arguments.

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit 7f84e3d into master Mar 27, 2025
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/openocdArgsOrder branch March 27, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the "openOcdLaunchArgs" setting before "openOcdConfigs" in the openocd startup line (VSC-1629)
3 participants