Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1615] use vscode env remoteName to detect codespaces #1483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brianignacio5
Copy link
Collaborator

Description

Code-server is uses web UI which makes user detection fail. Now we should check that the remote is Codespaces to disable specific commands.

Fixes #1461

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Configure ESP-IDF extension"
  2. Should not work in Codespaces.
  3. Running the Command in Code-server instance should work.

Test Configuration:

  • ESP-IDF Version: 5.3.1
  • OS (Windows,Linux and macOS): Codespaces and local

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Mar 24, 2025
@brianignacio5 brianignacio5 added this to the v1.10.0 milestone Mar 24, 2025
Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@Fabricio-ESP Fabricio-ESP changed the title use vscode env remoteName to detect codespaces [VSC-1615] use vscode env remoteName to detect codespaces Mar 25, 2025
@Fabricio-ESP
Copy link
Collaborator

Fabricio-ESP commented Mar 27, 2025

I confirmed that the extension is now able to distinguish a connection to a VSCode server and Github Codespaces. Allowing the installation of IDF version from the web interface on a VSCode Server environment.,
But noticed that after installing ESP-IDF, and attempting to open aa example project the ESP-IDF installation is shown twice ont eh dropdown menu:

image

report_DoubleIDFInstall.txt
93-bbec7f40cb8b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Will ESP-IDF EXTENSION support code-server (VSC-1615)
2 participants