Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSC-1631] fix created project path from task output #1485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brianignacio5
Copy link
Collaborator

Description

VSCode extension was parsing resulting project name from format namespace/name=1.0.0:example but for the example with this command

idf.py create-project-from-example "espressif/esp-modbus=2.0.2:tcp/mb_tcp_slave"

will generate a project named mb_tcp_slave instead of expected tcp/mb_tcp_slave.

Fixes espressif/esp-modbus#100

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Open ESP Component Registry."
  2. Search for esp-modbus. Select examples tab and click on tcp/mb_tcp_slave. Create a project example with the red button shown.
  3. Observe results. The example project should be created and a new window opened in the newly created project.

How has this been tested?

Test Configuration:

  • ESP-IDF Version: 5.3.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@Fabricio-ESP Fabricio-ESP changed the title fix created project path from task output [VSC-1631] fix created project path from task output Mar 25, 2025
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create project from examples in VSCode Extension (IDFGH-14767)
2 participants