Introduce user dashboard with 3 tabs #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the model of the actual "habilitation", which is a snapshot of the authorization request at the moment of validation. Will be implemented in the following commit
skelz0r
force-pushed
the
features/user-dashboard
branch
from
615b0c4 to
9345e25
Compare
Harden events factory and query object to keep it human readable
Do not overwrite contact attributes if specified
* Add more authorization requests to organization (not main user) * Add main user as contact on one of authorization request
skelz0r
force-pushed
the
features/user-dashboard
branch
4 times, most recently
from
ce83893 to
b0f46bb
Compare
Have to change request specs, we have 2 redirects now Closes https://linear.app/pole-api/issue/API-2120
Because of foreign keys we have side effects issues on CI with unclean data. No need to check this kind of complexity in tests, just wipe everything
skelz0r
force-pushed
the
features/user-dashboard
branch
from
b0f46bb to
2fc4676
Compare
* Within organization * With mentions
No need to show multiple steps, they can't do anything anyway
Decorator does not play nice with `class` instance method (it does not forward), we have to define an instance methods to access these attributes. Moreover, `model_name` renders the parent class instead of child, make it global in main decorator to avoid this error.
skelz0r
force-pushed
the
features/user-dashboard
branch
from
2fc4676 to
1b5e6b0
Compare
|
ça se lit commit par commit. ça a été un plus gros morceau que prévu 😅 |
Samuelfaure
approved these changes
Feb 1, 2024
| def perform | ||
| AuthorizationRequest.where("EXISTS ( | ||
| select 1 | ||
| from each(authorization_requests.data) as kv |
There was a problem hiding this comment.
key_value, c'est un objet ayant pour clé key et value. C'est peu important dans le contexte imo.
Comment on lines
+39
to
+43
| class Scope < Scope | ||
| def resolve | ||
| scope.where(organization: current_organization) | ||
| end | ||
| end |
There was a problem hiding this comment.
C'est comme class << self ici ?
There was a problem hiding this comment.
C'est la syntax Pundit, et ici le premier Scope est celui du namespace AuthorizationRequestPolicy, et le second celui de la classe mère.
|
@Isalafont je merge mais je t'invite à lire le code tout de même. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/pole-api/issue/API-2120/dashboard-demandeur-ouet-contact#comment-0d2692b1