Feature/dat 230 habilitation api captchetat #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Form models are now dynamically imported
Samuelfaure
force-pushed
the
feature/dat-230-habilitation-api-captchetat
branch
from
51fd6fc to
96d12ec
Compare
Samuelfaure
force-pushed
the
feature/dat-230-habilitation-api-captchetat
branch
from
96d12ec to
05b911f
Compare
skelz0r
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Techniquement je n'ai rien à dire.
D'un point de vue métier en explorant https://metabase.entreprise.api.gouv.fr/dashboard/50-datapass-exploration?nom_de_l%27api_(target_api)=api_captchetat&status_de_l%27habilitation=validated j'ai l'impression que la plupart des champs ne servent pas vraiment..
Faudrait voir avec @SchweisguthN, cependant vu le focus je pense que ce n'est pas un problème pour merger et itérer plus tard.
|
Je confirme, ils faisaient partie des FD qui demandaient à dégager quelques champs, mais en effet on peut merge et virer des champs plus tard. |
|
Vu que c'est fait, y'a moyen que tu les remontes dans la liste des FDs à contacter pour voir avec eux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ma première PR data_pass 🙏
fix https://linear.app/pole-api/issue/DAT-230/habilitation-api-captchetat