Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update change log for v3.6 to include details on deprecated flags. #19548

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Niket1997
Copy link

CHANGELOG: add decommissioned flags

To update the changelog with the deprecated flags that re decommissioned in v3.6.

Issue: 19492

Reference: This file in v3.5 contains the list of deprecated flags, also there is a comment against flags that are deprecated & decommissioned in v3.6.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Niket1997
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @Niket1997. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Niket1997 and others added 3 commits March 7, 2025 01:08
Signed-off-by: Niket1997 <aniket.mahangare@uber.com>
To update the changelog with the deprecated flags that re decommissioned in v3.6.

Signed-off-by: Niket1997 <aniket.mahangare@uber.com>
To update the changelog with the deprecated flags that re decommissioned in v3.6.

Signed-off-by: Niket1997 <aniket.mahangare@uber.com>
@Niket1997 Niket1997 force-pushed the add-removed-flags-info-changelog branch from 3eb68c2 to c7b41a7 Compare March 6, 2025 19:38
@ahrtr
Copy link
Member

ahrtr commented Mar 7, 2025

All the changes happened before we release v3.6.0-rc.0, so please update the v3.6.0-rc.0 changelog.

  • Please add an item "Removed v2 http proxy" under the section "Deprecations" something like below,
- Removed the [v2 http proxy](https://github.com/etcd-io/etcd/pull/14034). Note that the following flags have already been removed,
  - `--proxy`
  - `--proxy-failure-wait`
  - `--proxy-refresh-interval`
  - `--proxy-dial-timeout`
  - `--proxy-write-timeout`
  - `--proxy-read-timeout`
  • Also add an item "Deprecated v2store" under the section "Deprecations" something like below,
- Deprecated [v2store, v3store is the sole source of truth for the membership data](https://github.com/etcd-io/etcd/issues/12913). Note that the following flags have already been removed, 
  - `--enable-v2`
  - `--experimental-enable-v2v3`

Comment on lines +29 to +36
- `--enable-v2`
- `--experimental-enable-v2v3`
- `--proxy`
- `--proxy-failure-wait`
- `--proxy-refresh-interval`
- `--proxy-dial-timeout`
- `--proxy-write-timeout`
- `--proxy-read-timeout`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To double confirm: have you confirmed that this is a complete list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants