Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose types for ts #196

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

KianYang-Lee
Copy link
Contributor

The types should be exported, so that typescript can resolve the types. Made it so that it's exported. nuxt package is working fine so did not PR change.

Currently when importing to a Nuxt project with default tsconfig.json setting results in this during typecheck.

Could not find a declaration file for module '@vue-dapp/modal'. '/node_modules/@vue-dapp/modal/dist/modal.mjs' implicitly has an 'any' type.
There are types at '/node_modules/@vue-dapp/modal/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports".
The '@vue-dapp/modal' library may need to update its package.json or typings.

@johnson86tw
Copy link
Member

@KianYang-Lee Hi, thanks for fixing this issue!

I published these beta versions:

  • @vue-dapp/coinbase@1.5.6-beta.0
  • @vue-dapp/core@1.5.6-beta.0
  • @vue-dapp/modal@1.5.6-beta.0
  • @vue-dapp/nuxt@1.5.6-beta.0
  • @vue-dapp/walletconnect@1.5.6-beta.0

Can you try them out? If they work for you, we can merge this PR. Thanks!

@KianYang-Lee
Copy link
Contributor Author

@johnson86tw I tested on my machine, works ! Thanks

@johnson86tw johnson86tw merged commit 47f9ca4 into ethaccount:main Feb 21, 2025
1 check passed
@KianYang-Lee KianYang-Lee deleted the ky/add-types-to-export branch February 21, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants