-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): EIP-2537: Update vectors #1063
base: main
Are you sure you want to change the base?
Conversation
debf661
to
20780f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve, LGTM, assuming that the JSONs are copied from ethereum/EIPs#9217 👍 😄
Ruff does not apply E501 to lines that consist of a single "word"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, nice work @marioevz and @jochem-brouwer. The new cross-check is a really nice addition.
I spotted and cleaned up a couple of leftovers from the ruff migration #1058.
🗒️ Description
MUL precompile JSON files are not deleted as these are now used by calling the MSM precompile instead.
The generated fixtures are identical.
@jochem-brouwer
🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.