Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): EIP-2537: Update vectors #1063

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 8, 2025

🗒️ Description

MUL precompile JSON files are not deleted as these are now used by calling the MSM precompile instead.

The generated fixtures are identical.

@jochem-brouwer

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz force-pushed the update-2537-vectors branch from debf661 to 20780f2 Compare January 15, 2025 15:44
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve, LGTM, assuming that the JSONs are copied from ethereum/EIPs#9217 👍 😄

@danceratopz danceratopz added type:bug Something isn't working scope:tests Scope: Test cases labels Jan 15, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, nice work @marioevz and @jochem-brouwer. The new cross-check is a really nice addition.

I spotted and cleaned up a couple of leftovers from the ruff migration #1058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants